Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change blueprint to not need a synthesized test entrypoint #2071

Merged
merged 8 commits into from
Aug 30, 2024

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Aug 22, 2024

We no longer need to synthesize a dedicated test entrypoint, vite's built-in features (like eager import.meta.glob) are sufficient.

  • This will need test cleanup, as there are probably tests assuming the synthesized test entrypoint exists.
  • The other app templates need similar treatment to this one.

@ef4 ef4 force-pushed the no-test-entrypoint branch from 0b5f61a to d86a27a Compare August 22, 2024 18:35
@ef4 ef4 added the breaking label Aug 30, 2024
@ef4 ef4 merged commit b059849 into main Aug 30, 2024
190 checks passed
@ef4 ef4 deleted the no-test-entrypoint branch August 30, 2024 15:29
@github-actions github-actions bot mentioned this pull request Aug 30, 2024

{{content-for "body-footer"}}
{{content-for "test-body-footer"}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be removed? It's still created in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants